Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active
Date: 2016-07-13 07:11:38
Message-ID: CAM5-9D_r-0DvfzYSsDgO_tYNZgPaxVWQ17SNzmvBwz773_s1ng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jul 13, 2016 at 12:32 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Won't this result in incorrect graphs? I.e. chunks of data being missing
> (but not obviously so)?
>
Oh I see.. It might result in incorrect graphs..
Please ignore the patch.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK:http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On 13 Jul 2016, at 07:47, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
> wrote:
>
> Hi
>
> In Dashboard, the ajax calls to *render data grid* should only made, if
> dashboard panel is active.
> Currently it make ajax calls even if other panels like properties, sql are
> active.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
> <dashboard_render_if_panel_is_opened.patch>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-07-13 10:40:07 PATCH: To fix issue using PUBLIC as role (pgAdmin4)
Previous Message Dave Page 2016-07-13 07:02:23 Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active