Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi,
>>
>> I think we need more changes than just that;
>>
>> - The path at the top should not be editable (it should be greyed in fact)
>>
> Ok
>
>>
>> - The path at the top should only show the directory path. The
>> filename should never be appended.
>>
> Ok
>
>>
>> - The CSS needs to be fixed so the filename textbox at the bottom is
>> never hidden (as it is now if the dialogue opens at a small size).
>>
> Ok
>
>>
>> - Double-click to navigate vs. rename should be modified to work in
>> part like it does on Mac - Double-click on either the icon or the name
>> should open the item (browser into a folder, or select and "OK" on a
>> file), and Click then Enter should rename. I'm hesitant to try to
>> implement "slow double click to rename" as that would likely need to
>> be tunable for accessibility reasons.
>>
> Ok, I will fix it.
>
In the current scenario, the Enter Key is bound to the OK button by default
in Alertify dialog which servers the purpose of closing the dialog.
Should we de-attach Enter Key event bound to OK button and use it for
rename file?
please suggest what should I do?

On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > Please find the patch with issue fixed:
>> > File Browser - File does not exist error
>> >>
>> >> it is due to wrong path formation. strip the leftmost slash only from
>> the
>> >> file name selected not from the full path.
>> >
>> >
>> > Please review.
>> >
>> > Reply to the comments:
>> > The file browser is virtually unreadable (see screen shot), it does not
>> work
>> > like Mac app
>> > It seems to be font issue to me. I will fix it and send a patch.
>> >
>> > When I click on the folder name, it offers to change the folder name
>> instead
>> > of opening it (opening works when I click on the folder logo)
>> > we are performing two operations on double click:
>> > 1) Navigate inside the folder
>> > double clicking on folder icon allows to navigate inside the folder.
>> > 2) Rename folder
>> > double clicking on folder name allows to rename the file/folder.
>> >
>> > When I manage to navigate to the right file and want to open it, I get
>> a red
>> > message ‘File does not exist’. That message disappears after 2-3 seconds
>> > attached a patch with fix.
>> >
>> > Thanks,
>> > Surinder Kumar
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>