Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable
Date: 2016-05-27 11:30:00
Message-ID: CAM5-9D_Wa+rLv4vWX1EFLsfGtpL-+f2rCqSoSsDfapYPA52Y9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, May 27, 2016 at 4:43 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> > Hi
> >
> > Added support for Columns resizable in query tool. It allows user to
> resize
> > the table columns as much as needed.
> >
> > We are using Backgrid Sizeable Columns plugin:
> > https://github.com/WRidder/backgrid-sizeable-columns
> >
> > with one change in library on line no 185:
> > moved the following trigger event out of if condition:
> >
> > if (newWidth != oldWidth) {
> >
> > }
> >
> >
> > and added one additional parameter offset.
> > //Trigger event
> >
> > view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
> >
> >
> > We are listening to this trigger event in sqleditor.js file where we need
> > offset
> > to calculate new table width on every resize event.
>
> Please ensure any changes to third party libraries are submitted upstream.
>
yes, sure.

>
> > hence, here is the patch attached.
>
> ENOATTACHMENT!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sandeep Thakkar 2016-05-27 12:55:26 Re: Patch for pgAdmin4 RPM package
Previous Message Sanket Mehta 2016-05-27 11:22:16 Re: PATCH: graphical explain