Re: Lack of activity indicator over slow connections (pgadmin4)

Please find attached patch. Added activity indicator for:
1) Panels.
2) Dialog open and on click OK.(set cursor to progress)
3) Debugger. (Set cursor to progress).

Not done: Activity indicator is not implemented for wizard pages. send
another patch once completed.

On Fri, Sep 23, 2016 at 2:19 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> On Fri, Sep 23, 2016 at 1:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> >
>> >
>> > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> >> > Hi Dave/Ashesh
>> >> >
>> >> > The thing we can do is:
>> >> > 1) We can display loading message same as other panels if returned
>> >> > response
>> >> > is taking longer than 2 seconds, otherwise we won't display any
>> >> > message(to
>> >> > avoid fluctuations).
>> >> > Screenshot - demo_message.png
>> >>
>> >> There's a typo there (laoded)..
>> >>
>> >> > 2) Display a loading spinner along with panel title while data is
>> being
>> >> > loaded.
>> >> > Screenshot - spinner.png
>> >>
>> >> I don't see a spinner there at all.
>> >
>> > sorry its not spinner, its reload spinning icon in place of properties
>> icon.
>>
>> Oh, I see. I like it, but wonder if it would be too subtle.
>>
>> Can we do both? Show the panel, and spin a loading icon on the tab?
>>
> ​I will try to implement both.​
>
>>
>> >>
>> >>
>> >> What about the other places I mentioned?
>> >
>> >
>> >>
>> >> - On dialogue open and OK
>> >
>> > D
>> > isplay loading message
>> > in dialog till the data loads and on OK we can set mouse pointer to
>> > 'progress' till the data is not processed.
>>
>> Yes, they are essentially panels too, so we can do the same as for
>> Properties and Statistics etc.
>>
>> > - On Wizard steps
>> > D
>> > isplay loading message
>> > also in wizard pages till it doesn't loads data.
>>
>> Yes.
>>
>> >
>> > - Possibly in the debugger, when stepping?
>> >
>> > In case of debugger's step into, step out & resume, we can set mouse
>> pointer
>> > to 'progress'
>>
>> OK.
>>
>> Can you work up a patch ASAP please?
>>
> ​Ok.​
>
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>