| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: SqlFieldControl enhancements |
| Date: | 2016-08-23 06:43:29 |
| Message-ID: | CAM5-9D9u4AzSbpH_6Cim25GBbxop_Kh_FBGFt66-c2n50GtEQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
Following are the enhancements:
1) Disable cursor mode if editor is disabled.
if cursor is enabled. on pressing keys, a false event is generated and on
validating models it causes Save button to enable.
2) If editor is disabled, set dark background colour.
3) CodeMirror corners seems to cut around. CodeMirror z-index is greater
than pgadmin-control class which causing issue. it is fixed.
4) CodeMirror not taking full height. set *line-height *css property to fix
the issue.
Please find attached patch and review.
Thanks,
Surinder Kumar
| Attachment | Content-Type | Size |
|---|---|---|
| sqlfieldcontrol_enhancements.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2016-08-23 07:08:02 | Fixed RM #1209 Trigger issues through right click |
| Previous Message | Ashesh Vashi | 2016-08-23 04:02:19 | pgAdmin 4 commit: Cleanup old code in server_groups.js. Fixes #1247 |