Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

On Tue, May 24, 2016 at 1:35 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> On Tue, May 24, 2016 at 1:34 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Tue, May 24, 2016 at 12:35 PM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi
>>>
>>> *Issues fixed:*
>>> *1. *ReferenceError: assignment to undeclared variable t_res in
>>> FileManager
>>> *2.* Add missing default case in switch statement.
>>> *3.* code improvements.
>>>
>>
> What are those, can you please **share** some insight?
>
1. Added curly braces for If statements.
2. Removed unnecessary code which was setting dialog_title twice.

>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>>
>>> issue #1 is reproduced on mozilla browser of ubuntu machine when
>>> FileManager is opened for the first time in Backup server tool.
>>> Thanks to Neel for reporting the issue #1.
>>>
>>> Please review the patch.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>