From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards |
Date: | 2017-04-12 12:52:36 |
Message-ID: | CAM5-9D9MEf1LALx2eBAH+Z7B_pOr022c4xBHqbTSEkAmb-Ci=w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Please find rebased patch.
On Wed, Apr 12, 2017 at 5:44 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Can you rebase this please?
>
> On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar
> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >> > Hi
> >> >
> >> > When a server is disconnected, listen to
> >> > 'pgadmin:server:disconnect'event
> >> > and trigger refresh button of Server Activity data.
> >>
> >> I don't see any reason to do that - it's not auto-refreshed data, so
> >> why clear it?
> >
> > Hmm. i agree.
> >>
> >>
> >> > Also, on server disconnect, an unused event 'server-disconnected' is
> >> > being
> >> > triggered.
> >> > instead it should trigger ''pgadmin:server:disconnect'event.
> >
> > Please find attached patch for same.
> >>
> >>
> >> Please submit that as a separate cleanup patch.
> >>
> >> Thanks.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
cleanup_server_js_v1.patch | application/octet-stream | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-04-12 13:33:36 | Re: [question] |
Previous Message | Dave Page | 2017-04-12 12:30:16 | Re: [pgAdmin4][PATCH] To fix the issue in browser tree |