Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Robert Eckhardt <reckhardt(at)pivotal(dot)io>
Cc: Shirley Wang <swang(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Date: 2017-06-15 06:24:48
Message-ID: CAM5-9D9EtyfszgZT1Gi6pmqMuQxOnXaQpFcc0RhYi_OtN3dRng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jun 14, 2017 at 11:14 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
wrote:

> I think you are thinking along the right lines. I guess the question is,
> if the text is too long, will the name still be readable somehow.
>
> Use case I am thinking of.
>
> Given I have the 'same database' only with data sharded by region or
> something, An instance for Sales in USA, EMEA, APJ, etc. Then it is likely
> I might have the same queries to run on all of those servers.
>
> Can I easily tell which server it is without necessarily clicking to the
> open tab?
>
> I like the way Brave Browser works, If you hover over the tab you can see
> exactly what is being displayed. Maybe something similar (not that exactly
> because it seems like a railroad spike when a tack would do).
>
​What we can do is fix the tab width and set tooltips when hover over the
tab.

>
> If I am opening a saved query will the name of the saved file be shown?
>
​Yes it displays in Panel title.​

>
> This is great. I find the lack of meaningful names to be personally
> annoying and users have commented on it too.
>
>
> -- Rob
>
> On Wed, Jun 14, 2017 at 10:32 AM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>
>>
>>
>> On Tue, Jun 13, 2017 at 11:29 AM Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar <
>>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang <swang(at)pivotal(dot)io>
>>>>> wrote:
>>>>>
>>>>>> Awesome!! This is super helpful :)
>>>>>>
>>>>>> Does this affect a new query window (currently the title is 'Query -
>>>>>> untitled')?
>>>>>>
>>>>> ​Yes, in this case the title of query window will be Query -
>>>>> [db_name] on [server_name]. It was showing 'Query - untitled' when
>>>>> opened from context menu because no tree information was passed.
>>>>>
>>>>
>>>> I know you enabled ellipses for names that are too long, but if it's a
>>>> database name and server name in a tab, I think that all the tabs will have
>>>> ellipses. Considering that, what if we just shorten it to the database
>>>> name, especially since the blue bar where you type the SQL has the name of
>>>> the server.
>>>>
>>> ​Yes ellipses and tooltips are used if name is too long.
>>> ​But what I think is the title has all useful information about the
>>> database and server it is connected to, considering the case:
>>>
>>> 1) When multiple instances of query tool are opened in New Tab/Window.
>>> or when a user has multiple screens.
>>>
>>> 2) If a user is parallely running multiple instance of query tool for
>>> different databases of different servers. server name will help uniquely
>>> identify the tab.
>>>
>>
>> My concern is the character limit for tab names will always shorten what
>> a user will see in the tab, unless the tab has no limit (which I do not
>> think we should do). Database names might be extremely long.
>>
>> For example, even if your database name is 'postgres', then there are 20
>> characters before the server name making the tab really long. [Query -
>> postgres on server_name]
>> [image: Screen Shot 2017-06-14 at 10.22.51 AM.png]
>> Unless they can see the server name quickly, I don't think we're solving
>> for this use case.
>>
>>
>>> 3) The panel can be moved out of Panels tab by dragging out, so the
>>> panel title must have server and database information.
>>>
>>> considering the above cases, I think the blue bar could be removed If
>>> query tool title already have server and database information.
>>>
>>
>> something like this?
>> [image: Screen Shot 2017-06-14 at 10.28.21 AM.png]
>>
>>
>>
>> Another option: Given that the lightening bolt is an indicator for
>> queries, is there a need to keep Query in the name?
>> [image: Screen Shot 2017-06-14 at 10.25.36 AM.png]
>>
>>
>>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-06-15 08:56:18 [pgAdmin4][PATCH] To fix the issue in Grant wizard
Previous Message Surinder Kumar 2017-06-15 06:24:24 Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title