Re: [pgAdmin4] [Patch]: Grant Wizard

Hi,

PFA patch with following issues fixed:

1. Fixed 'get_schemas.sql' template for PPAS. It was fetching system
level schemas due to wrong sql query.
2. Allowed the grant wizard to open on procedures node if server type is
PPAS.

Also, I will send another patch for the remaining issues.

On Wed, Apr 13, 2016 at 8:41 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Apr 8, 2016 at 6:59 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> PFA patch with resolved review comments.
>>
>> On Fri, Apr 8, 2016 at 12:52 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> Nearly there :-). Assuming no regressions, I believe we'll be ready to
>>> commit once the following issues are resolved:
>>>
>>> - The select object grid should fill the available vertical space in the
>>> dialogue - at present there's a gap below it.
>>>
>> Done
>>
>
> This does not seem to be fixed (see attached screenshot). In fact, the gap
> gets bigger proportionally as the window is resized.
>
>
>>
>>> - When selecting privileges, each time I click on a checkbox, the row
>>> closes. Similar grids elsewhere in the app close the row when the cell
>>> loses focus, *however*, that is also the incorrect behaviour - the row
>>> should only close when the row itself loses focus (and should open when it
>>> gets focus).
>>>
>> I checked the row closes either when gets clicked on row or outside row,
>> it doesn't seems to close on click on checkbox.
>>
>
> This is still broken for me. I'm using Chrome on OS X. As soon as I click
> any checkbox, the row closes, and I have to click again to see the
> checkboxes again.
>
> One additional issue:
>
> - If I select some objects and permissions (in my case, everything in a
> PEM database, and ALL), hit Next so I can see the SQL, then hit back
> *twice*, I see the second attached screenshot.
>
> I'm going to commit the code with these issues as they are largely
> cosmetic. Please submit a patch to fix them (I'll add a new card to our
> internal Kanban chart).
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>