Re: [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 4:05 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >
> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
> >> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >> >>
> >> >> And then I find a problem. Sigh.
> >> >>
> >> >> When running in the desktop runtime, under QtWekKit (the forked,
> >> >> updated version that is by far the best of the browser engines we've
> >> >> used), we get the attached error at startup. I don't see this under
> >> >> QtWebEngine, though as we've already found, that's not usable for
> >> >> other reasons.
> >> >>
> >> >> Is this fixable?
> >> >
> >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> >> > "
> >> > WebKit engine itself has not been updated since Qt 5.2 release. That's
> >> > why
> >> > it didn't support recent changes in Web standards that happened after
> >> > 2013,
> >> > including: new JavaScript language standard ES2015 (also known as
> ES6),
> >> > as
> >> > well as improvements in DOM API and CSS.
> >> > ...
> >> > "
> >> >
> >> > Could this be a reason?
> >>
> >> For the old webkit, certainly, but if you read further down, the
> >> version we're using has been updated and does now claim to support
> >> most of ES2015.
> >
> > In fact the modern browsers don't support ES6 JS so the JS files
> containing
> > ES6 code are first transpiled using babel into JS that browsers supports.
>
> Well, we *could* do that, but are we? I'm not sure the current code
> does anything more than lint and webpack it.
>
​Yes. babel is used in webpack config which converts JSX, JS and react JS
library code into browser supportable JS code and put them into generated
directory which we are then imported in sqleditor.js

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>