From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Shruti B Iyer <siyer(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
Subject: | Re: Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool |
Date: | 2017-06-06 08:22:46 |
Message-ID: | CAM5-9D8yKkmvVdhexSK7qaCP3UUr3ORk9D7TNnPwJVJW=LSx7A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi All,
Please find updated patch which includes Jasmine test cases for functions
getHash and calculateColumnWidth
Thanks,
Surinder
On Mon, Jun 5, 2017 at 11:38 PM, Shruti B Iyer <siyer(at)pivotal(dot)io> wrote:
> Hi Surinder!
>
> We reviewed this patch. The changes look good and we especially like that
> you have extracted out the new utility functions and the epicRandomString
> function too.
>
> This patch will likely affect the Query Results patch that is currently
> under review
> <https://www.postgresql.org/message-id/flat/CAAtBm9V-tNQrtjxt4n8JJek5M4v9KW_h3sgbL1ydcBB%2BtLus2w%40mail(dot)gmail(dot)com#CAAtBm9V-tNQrtjxt4n8JJek5M4v9KW_h3sgbL1ydcBB+tLus2w(at)mail(dot)gmail(dot)com>.
> In order to assist either us or yourself when making a merge between these
> patches, it would help to have jasmine unit testing for the two new
> functions, getHash and calculate_column_width.
>
> Also, we suggest that you rename calculate_column_width to
> calculateColumnWidth for consistency with javascript code style.
>
> Thanks,
> Shruti and Matt
>
> On Mon, Jun 5, 2017 at 9:16 AM Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Staged changes are missed in previous patch, so please ignore.
>> Please find attached updated patch.
>>
>> On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi
>>>
>>> This patch contains two fixes:
>>>
>>> 1) In Query/tool or Edit grid, the width of table column header is fixed
>>> depending on the column type(int, boolean, char etc.) due to which the
>>> column name or type appears cut from right and doesn't looks good from user
>>> point of view. The main concern was to display as much as the content of
>>> column should be displayed.
>>>
>>> Now the width of column is decided using the text length of column name
>>> or column type so that the column takes exact width it required and it
>>> don't appears cut.
>>>
>>> 2) Remember column size after re-running a query.
>>>
>>> The approach is to extract table name from the query executed and use it
>>> to store its columns width.
>>> Whenever the column(s) width of a table is adjusted, the corresponding
>>> values are updated into the object and used every time the same query is
>>> executed.
>>>
>>> If a query is executed for e.g:
>>>
>>> SELECT generate_series(1, 1000) as id, generate_series(1, 1000) as name,
>>> generate_series(1, 1000) as age
>>>
>>> it
>>> displays 3 columns
>>> but don't have any table name. In that case,
>>> i use a hash generator function which returns unique hash for a query
>>> written in query editor and adjusted column(s) width are stored against
>>> that hash in object.
>>>
>>> Is there any way to get temporary table name(avoiding unique hash) for
>>> such queries ?
>>>
>>> Also, Moved utilities functions into pgadmin/static/utils.js
>>>
>>> Please find attached patch and review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
Attachment | Content-Type | Size |
---|---|---|
Feature_1971_with_jasmine_tests.patch | application/octet-stream | 10.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-06-06 08:32:44 | Re: Declarative partitioning in pgAdmin4 |
Previous Message | Harshal Dhumal | 2017-06-06 06:42:09 | Re: Fix for RM2421 [pgAdmin4][patch] |