[pgAdmin4][Patch]: Slickgrid loading issue in Query tool

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: Slickgrid loading issue in Query tool
Date: 2016-09-19 13:58:49
Message-ID: CAM5-9D8fkGNhktgspPc2wS78EEnxtzgCaQsaXADcn0oV=dLhoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

*Issue:*
Slick-grid libraries loads when an instance of query tool is opened. But
sometimes it throws exception "jQuery is not defined" and it doesn't opens
up.

*Solution:*
As per my understanding, In *datagrid/index.html* file, we set the order of
loading libraries such as
*require(['jquery', 'pgadmin', 'pgadmin.sqleditor']) *
but it still loads *pgadmin.sqleditor.js* file before *jQuery* for unknown
reason.

To fix this, we load *pgadmin.sqleditor.js* file using *require([],
function(){}) *module loader which ensures that the code within
*function(){}* will be executed when pgadmin.sqleditor.js is loaded.

Please find attache patch.
This issue is fixed by *Ashesh Vashi*.

Thanks,
Surinder Kumar

Attachment Content-Type Size
slickgrid_js_load_issue.patch application/octet-stream 4.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-09-19 14:03:35 [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
Previous Message Navnath Gadakh 2016-09-19 13:03:52 Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary