From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Subject: | Re: [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button |
Date: | 2016-09-20 09:22:53 |
Message-ID: | CAM5-9D8_pg1u6OxWcDPy+SxOdVf_PiQH7N57bL1=dL4KNn8suw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, Sep 19, 2016 at 9:49 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
>
> On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> > Hi
> >
> > Please find patch with following fixes:
> >
> > 1) Newly added server-group not listing in tree view.
> >
> > 2) On creating a first node for collection node with no child. the
> created
> > node doesn't show up under its respective parent node.
> > - to add a node to child under its parent node. its parent node attribute
> > must be set 'inode: true' but it always gets false for inode that doesn't
> > add the node.
> >
> > Ashesh - Can you please review it?
>
> I tested this by adding a sequence to a database and schema that
> didn't previously contain any. The node was not added, and in the
> Javascript console I get:
>
> browser.js:1108 Failed to append
This issue is taken care in updated patch, Also properly handled the case
for 'server-group' not listing in tree view, thus removing
'addNodeWithNoParent' method from previous patch.
I have tested it for most of the nodes, it works.
Please find updated patch and review.
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM1627_v1.patch | application/octet-stream | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-09-20 09:46:37 | PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4) |
Previous Message | Dave Page | 2016-09-20 09:03:14 | Re: [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL |