Re: [pgAdmin4][Patch]: To fix database disconnect option

Hi

As discussed the disconnect option is not working due to javascript error:
"obj is undefined" and which is after web packing. so in some files global
variables needs to convert into local var.

We need to run eslint on each file to find out such issues and fix all at
once. So i am writing a new entry "yarn run eslint /path/to/module/" in
package.json > scripts as Ashesh suggested, so that everytime before
submitting/commiting a patch, running eslint can prompt such errors.

Thanks Murtuza for fix.

Thanks,
Surinder

On Fri, Jul 21, 2017 at 3:41 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, applied.
>
> On Fri, Jul 21, 2017 at 10:08 AM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the issue where database disconnect option is not
>> working.
>>
>> *Steps to re-produce:*
>> 1) Create a "test" database
>> 2) Connect to "test" database
>> 3) Right click on "test" database and try to disconnect it, you will get
>> an error on console.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>