Re: pgAdmin 4 v2.0-rc1 builds

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Anthony DeBarros <adebarros(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 v2.0-rc1 builds
Date: 2017-09-11 13:12:02
Message-ID: CAM5-9D8Prt-WHovZeRvMXrFRjDiVX=Ze5AuME8F-34YQx5HdNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Sep 11, 2017 at 6:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros <adebarros(at)gmail(dot)com>
>> wrote:
>>
>>> Howdy,
>>>
>>> Nice work! Don’t see any show-stoppers, but I’ll throw three comments at
>>> you all.
>>>
>>> 1. New tree icons look great.
>>> 2. A few weeks back, there was a test release with a new font for the
>>> query tool. Got used to it and liked it a lot. Hope you consider using it
>>> in the future.
>>> 3. Still experiencing this bug in the History tab on MacOS:
>>> https://redmine.postgresql.org/issues/2561
>>>
>> ​This is an issue when pgAdmin4 run/built in dev mode​. It would be
>> resolved when pgAdmin4 built in production mode.
>>
>> However, I had sent a patch to run builds in production mode. But as per
>> discussion with Dave, we need to add another target for production mode on
>> which I will work once i get time.
>>
>
> Can you get that done for tomorrow?
>
​If I start working​

​on this tomorrow. I can add target to the build files but I am not sure it
will be completed by tomorrow because it needs testing on all possible
Operating Systems​ plus on runtime as well.
It it gets completed by tomorrow then I will send a patch for it, otherwise
this task will require more time.

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-09-11 13:15:08 Re: pgAdmin 4 v2.0-rc1 builds
Previous Message Ashesh Vashi 2017-09-11 12:54:10 pgAdmin 4 commit: Using the svg icons for domain constraint, and server