| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Matthew Kleiman <mkleiman(at)pivotal(dot)io>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7 |
| Date: | 2017-06-23 10:53:43 |
| Message-ID: | CAM5-9D8Mm1tji6=iuoJO8rWKUEhWX7598JDE5f83AJkW0onvAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, Jun 23, 2017 at 4:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Sorry, I forgot to attach screenshot.
>> I looked into Query tool HTML using inspect tool.
>>
>>
> That's code that's part of SlickGrid isn't it? If there are improvements
> to be made there, patches should be sent upstream. We don't want to modify
> (and thus have to vendorise) 3rd party code unless it's absolutely
> essential.
>
Yes its part of SlickGrid and changes should go into slick grid repo.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2017-06-23 12:35:51 | Re: [pgAdmin4][Patch] To fix the issue in Debugger module |
| Previous Message | Dave Page | 2017-06-23 10:51:31 | Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7 |