| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog |
| Date: | 2016-09-12 05:12:13 |
| Message-ID: | CAM5-9D8KtB8xSrL3z90CG_VEPm002oAPA-s3d3CHGR9p6Q3iMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
*Please find attached with following fixes:*
1) The function '*canCreateProc*' that checks if package is auth to create
under catalog gets failed due to improper check of 'type'. Instead check
should be like
node_hierarchy['server'].*server_type* == "ppas" not
node_hierarchy['server'].*type* == "ppas"
2) Also found, *package.js* was loading at schema level, due to this,
context menu doesn't popup under catalog. Now it is load at database level.
3) In *package.js*, remove extra comma from columns array.
4) Rule create option should not available on table under catalogs. Fixed.
Please review.
Thanks,
Surinder Kumar
| Attachment | Content-Type | Size |
|---|---|---|
| RM1682.patch | application/octet-stream | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2016-09-12 05:43:30 | Re: [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog |
| Previous Message | Ashesh Vashi | 2016-09-11 09:27:10 | Re: python-click dependency |