Re: Unified server/desktop config

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Unified server/desktop config
Date: 2017-08-07 11:03:06
Message-ID: CAM5-9D8Ko_we_jAuBhP6yLtu_VtcR0QCQJE1SC1zS0vcMBJ4uQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Aug 7, 2017 at 4:11 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> On Mon, Aug 7, 2017 at 3:59 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Anyone?
>>
> Surinder - please give this one priority.
>
Sure
​.​

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>> On Thu, Jul 20, 2017 at 5:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> All,
>>>
>>> Attached is a patch that aims to allow us to have a standardised config
>>> that will work out of the box for both web and desktop modes. It does this
>>> by doing two things:
>>>
>>> 1) The runtime sets SERVER_MODE in the Python environment before
>>> starting the app. If this value is set, then it overrides the default value
>>> of SERVER_MODE in the config.
>>>
>>> 2) The config file then offers default values for the various file
>>> locations for both server and desktop mode, setting them appropriately
>>> based on the derived SERVER_MODE value.
>>>
>>> The only downsides I can see from this are:
>>>
>>> - You cannot run in server mode in the runtime without manually
>>> reconfiguring SERVER_MODE and likely a bunch of paths in config_local.py
>>>
>>> - If you want to override SERVER_MODE, you'll probably also need to
>>> redefine the various paths in config_local.py.
>>>
>>> I don't see either being something 99.9% of users would need though.
>>>
>>> Can anyone see if the patch breaks anything, or if I missed any side
>>> effects?
>>>
>>> Is it likely to break things during upgrades? I suspect so... so maybe
>>> this should prompt v2.0?
>>>
>>> I'd appreciate multiple reviews of this, as it could break things. Note
>>> that I haven't yet updated the docs.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-08-07 12:43:03 Re: Unified server/desktop config
Previous Message Ashesh Vashi 2017-08-07 10:41:31 Re: Unified server/desktop config