From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Python2.6 compatibility fixes (pgAdmin4) |
Date: | 2016-09-09 12:53:34 |
Message-ID: | CAM5-9D8HqnVfK6DTv=HXAmSNPq8iBP4x-57RAGQtk9juqncdWA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
*Please find attached patch with following fix:*
1) While running pgAdmin4 with latest git pull on Windows x64 environment,
I got an exception on terminal console,
> NameError
> NameError: global name 'arch_keys' is not defined
*Issue:* arch_keys was defined inside the method add_server, but used
outside the method.
I have handled this issue in attached patch.
On Tue, Sep 6, 2016 at 6:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, patch applied.
>
> On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > +++ Adding related RM.
> >
> > RM#1636 & RM#1659
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala
> > <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >>
> >> Hi,
> >>
> >> PFA minor patch for Python2.6 compatibility with pgAdmin4.
> >> Please review.
> >>
> >>
> >> Regards,
> >> Murtuza Zabuawala
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
Attachment | Content-Type | Size |
---|---|---|
py_26_fix.patch | application/octet-stream | 842 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-09-09 13:45:37 | pgAdmin 4 commit: Fix error highlighting, broken in d6391c7e9b26e5e10bb |
Previous Message | Murtuza Zabuawala | 2016-09-09 12:36:48 | PATCH: To fix the issue of highlighting error in the query tool (pgAdmin4) |