Re: [pgAdmin4] [Patch]: Grant Wizard

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [Patch]: Grant Wizard
Date: 2016-03-10 09:50:54
Message-ID: CAM5-9D-bSJx-u_K+o2eQhd8r_39+CTxmabg9wkXP_NzVu9Eo2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Please apply Khusboo's patch for "Privileges macros under Schema" before
using grant wizard patch.

On Thu, Mar 10, 2016 at 2:52 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch after rebasing.
>
> On Wed, Mar 9, 2016 at 11:04 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Sorry Surinder - can you rebase this please? I think it was broken by
>> 8a7ec6b45221f042bc39c9bce2c577e12b43cc3a :-(
>
>
>>
> How much work would it be to enable it to work at database level as well?
>
> It depends on whether we need to enable grant wizard for all nodes under
> database level or
> enable it for specific nodes under database level.
>
>>
>> On Tue, Mar 8, 2016 at 1:48 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > The menu option is dependent only on certain nodes like:
>> >
>> > 1. Schema Node
>> > 2. Views Collection Node
>> > 3. Tables Collection Node
>> > 4. Sequences Collection Node
>> > 5. Functions Collection Node
>> >
>> > It will be enabled on click of above listed nodes.
>> >
>> > On Tue, Mar 8, 2016 at 6:57 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>
>> >> On Tue, Mar 8, 2016 at 10:00 AM, Surinder Kumar
>> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> >> > Hi,
>> >> >
>> >> > I forgot to add 'node.ui.js' file in the previous patch, please
>> ignore
>> >> > the
>> >> > previous patch.
>> >> > Attached is the new patch,
>> >> >
>> >> > Please review the patch and let me know for any comments.
>> >>
>> >> Is this dependent on any other patches? The menu option never seems to
>> >> be enabled for me when I test against git-master.
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-10 11:56:50 Re: [pgAdmin4] [Patch]: Grant Wizard
Previous Message Ashesh Vashi 2016-03-10 09:27:23 pgAdmin 4 commit: Resolved typos in SQL templates for PPAS