Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi
Review comments:

1.

For consistency, we use two spaces for indentation in CSS files. Four
spaces are used in _dashboard.scss file. The configurations are defined
in web/.editorconfig file.
2.

In,dashboard.css Can we return function object in return instead of
function class itself, this will eliminate the need of creating function
object every time we use info and error?
3.

On Dashboard, I can see Postgres icon is misaligned compared to other
icons in Getting Started section. It is not related to this patch.
adjusting margin top will fix it.
4.

I tried to test out Error message displayed, but I encounter an
error(screenshot attached).
Steps to reproduce:
- Open pgAdmin4 in browser
- Connect to PostgreSQL Server, Keep dashboard tab open.
- Navigate to the database which is connected.
- Now disconnect pgAdmin4 python server.
- No error message is displayed on Dashboard because it breaks in JS
as xhr.responseText is empty.
However, it might be an existing issue.

Thanks,
Surinder

On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:

Hi Ashesh,
>
> That's correct. This patch just changed alert style in the 'tabs',
> such as Dependency and Dependents.
>
> Thanks
>
> Wenlin
>
> On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Surinder,
>>
>> Please take a look at this patch.
>>
>> If I recalls correctly, this patch is related to styling of the 'tabs'
>> shown on the main window.
>> Wenlin - please correct me if my understanding is wrong.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Mon, Aug 7, 2017 at 8:11 AM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>> wrote:
>>
>>> Hi hackers,
>>>
>>> Could you please review this patch?
>>>
>>> Thanks
>>>
>>> Wenlin and Sarah
>>>
>>> On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> This patch changes the alert style in the sub-navigation to match style
>>>> guide.
>>>>
>>>> Thanks,
>>>> Wenlin, Shirley & Sarah
>>>>
>>>>
>>>>
>>>
>>
> ​