Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node
Date: 2016-06-03 10:01:03
Message-ID: CAM5-9D-QEO1TngHhG24ZJTxA+oQqzJo6a7PgyQaUbf-ZXR+_wQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached patch for:
1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and
functions

Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL
pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix
that, now we have used both 'create.sql' and 'get_definition.sql' templates
to generate full SQL query
for SQL pane.

Please review.

On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Please ignore this patch. I will send another patch.
>
> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find attached patch for RM#1293.
>> Add support to display GRANT privilege query in SQL Pane.
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>

Attachment Content-Type Size
fix_for_RM#1293_and_RM#1294.patch application/octet-stream 33.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-06-03 10:01:52 pgAdmin 4 commit: Fixes #1275 Issue with Query tool for PPAS - not show
Previous Message Murtuza Zabuawala 2016-06-03 10:00:59 PATCH: To fix issue in table node (pgAdmin4)