[pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: Fixes #1940 - Handle non-ascii characters in file/folder names
Date: 2016-11-24 10:44:34
Message-ID: CAM5-9D-MbhJHNeJRpNRGwr-mxvSKrKMTwDu7p-A9Ju6NMOh6Yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

This patch handles encode/decode issues for files names when following
operations are performed such as "create/rename/delete/download/upload" or
browsing a file etc.

*Changes in code:*
1) Removed cleanstring() js function which converts ascii characters into
its alphabetical characters.
We support ascii characters for file/folder name.
2) Read/Write file in bytes mode(rb/wb) as file need not be always text
file.
3) The title of query tab is currently shown encoded, it should be decoded
while displaying in tab title.

Please find attached patch and review.

Thanks,
Surinder Kumar

Attachment Content-Type Size
RM_1940.patch application/octet-stream 7.9 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2016-11-24 10:51:37 [Patch]: RM#1979 - Editing Function Issues
Previous Message Harshal Dhumal 2016-11-24 10:25:42 Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]