From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: B-Tree support function number 3 (strxfrm() optimization) |
Date: | 2014-09-15 17:34:39 |
Message-ID: | CAM3SWZTQ1JfpXzV+Zd4MK_gc=YWYBeArdi4CEU=f_PuWQuL_Sw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 15, 2014 at 10:17 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> It strikes me that perhaps we should make this change (rearranging
> things so that the memcmp tiebreak is run before strcoll) first,
> before dealing with the rest of the abbreviated keys infrastructure.
> It appears to be a separate improvement which is worthwhile
> independently of what we do about that patch.
I guess we could do that, but AFAICT the only open item blocking the
commit of a basic version of abbreviated keys (the informally agreed
to basic version lacking support for single-attribute aggregates) is
what to do about the current need to create a separate sortsupport
state. I've talked about my thoughts on that question in detail now
[1].
BTW, you probably realize this, but we still need a second memcmp()
after strcoll() too. hu_HU will care about that [2].
[1] http://www.postgresql.org/message-id/CAM3SWZQCDCnfWd3qzoO4QmY4G8oKHUqyrd26bBLa7FL2x-nTjg@mail.gmail.com
[2] http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=656beff59033ccc5261a615802e1a85da68e8fad
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2014-09-15 17:46:29 | Re: pgbench throttling latency limit |
Previous Message | Robert Haas | 2014-09-15 17:30:46 | Re: [v9.5] Custom Plan API |