| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: relscan_details.h |
| Date: | 2013-10-02 02:23:57 |
| Message-ID: | CAM3SWZTAMKcRv5Di7RSB6ssbcwJ3iN2TLkbTs8s5q7ZEn0p8Vg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 17, 2013 at 12:59 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Personally, I'm not particularly in favor of these kinds of changes.
+1. Experience has shown this kind of effort to be a tarpit. It turns
out that refactoring away compiler dependencies has this kind of
fractal complexity - the more you look at it, the less sense it makes.
I would be in favor of this if there were compelling gains in either
compile time (and like others, I have a pretty high bar for compelling
here), or if the refactoring effort remedied a clear modularity
violation. Though I think it has to happen every once in a while, I'd
suggest about every 5 years as the right interval.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-10-02 02:29:07 | Re: [PATCH] Add use of asprintf() |
| Previous Message | Bruce Momjian | 2013-10-02 02:12:05 | Re: relscan_details.h |