Re: 9.5 release notes may need ON CONFLICT DO NOTHING compatibility notice for FDW authors

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: 9.5 release notes may need ON CONFLICT DO NOTHING compatibility notice for FDW authors
Date: 2015-05-25 00:16:24
Message-ID: CAM3SWZSaT1H7SirG79u81fbdDGETDFjL5nyHYkoS6Dy-trmRQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 24, 2015 at 4:22 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> As things stand, every other possible ON CONFLICT clause will throw an
> error in some way before the FDW is consulted at all, so FDW authors
> need not concern themselves with those other cases (unless perhaps we
> allow ON CONFLICT DO UPDATE to not require an inference specification
> in a last minute behavioral tweak, as suggested by Simon Riggs, making
> ON CONFLICT DO UPDATE support by foreign data wrappers a possibility
> that must be considered).

AddForeignUpdateTargets() actually won't be called with ON CONFLICT DO
UPDATE, and so it isn't exactly true that the only obstacle to making
FDWs support ON CONFLICT DO UPDATE is around inference of arbiter
unique indexes on the foreign side. It's *almost* true, though.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-05-25 00:41:23 Re: 9.5 release notes may need ON CONFLICT DO NOTHING compatibility notice for FDW authors
Previous Message Andres Freund 2015-05-25 00:07:35 Re: problems on Solaris