| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Funny representation in pg_stat_statements.query. |
| Date: | 2014-01-21 19:48:32 |
| Message-ID: | CAM3SWZRy_onM2P7P8=DL7=COxQ31RG2RFe+9yZ_3W=qenAyqLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2014 at 12:30 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> The fundamental cause of this issue is Const node which conveys
> the location of other than constant tokens. Any other nodes, for
> instance TypeCasts, are safe.
>
> So this is fixed by quite simple way like following getting rid
> of the referred difficulties of keeping the code sane and total
> loss of token locations. (white spaces are collapsed for readability)
There was a more obvious case of this that I noticed during the
development of pg_stat_statements query normalization. As you may have
noticed, that was addressed by this commit:
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-01-21 19:48:41 | Re: Add min and max execute statement time in pg_stat_statement |
| Previous Message | Robert Haas | 2014-01-21 19:45:54 | Re: ALTER SYSTEM SET typos and fix for temporary file name management |