From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
Subject: | Re: INSERT ... ON CONFLICT {UPDATE | IGNORE} |
Date: | 2014-09-25 18:43:08 |
Message-ID: | CAM3SWZRuLFu5CgUdVri5vNkGcmkmKy-mDmn2oOCDf+BQCfR-=g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 25, 2014 at 7:35 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Sep 25, 2014 at 10:12 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> IMHO it is impossible to know if any of the other code is correct
>> until we have a clear and stable vision of what the command is
>> supposed to perform.
>
> +1.
>
>> The inner workings are less important than what the feature does.
>
> +1.
>
>> FWIW, the row available at the end of all BEFORE triggers is clearly
>> the object we should be manipulating, not the original VALUES()
>> clause. Otherwise this type of INSERT would behave differently from
>> normal INSERTs. Which would likely violate RLS, if nothing else.
>
> +1.
I agree with all of this. I'm glad that my opinion on how a
CONFLICTING() expression interacts with BEFORE triggers is accepted,
too.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-09-25 18:46:18 | Re: jsonb format is pessimal for toast compression |
Previous Message | Tom Lane | 2014-09-25 18:39:37 | Re: jsonb format is pessimal for toast compression |