Minor issue with BRIN regression tests

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Minor issue with BRIN regression tests
Date: 2015-06-02 02:35:25
Message-ID: CAM3SWZRsE0OB6Pap2Sy+ZzKTDF0Tfkb5wpn17382RhhQ00Up2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached patch adjusts BRIN regression tests to make a non-obvious
dependency on tuple order explicit. Currently, an index-only scan plan
is used by the query that I've adjusted. I'd rather be sure that that
continues.

This was spotted while running the regression tests with the Postgres
default B-Tree fillfactor significantly reduced. There was only one
other failure, but that one was really obvious; in general I wouldn't
bother with "fixing" such things. This, however, seems problematic,
because insertion order matters for the purposes of the test. It's
perhaps implied that the test consistently relies on the stable order
of things within the tenk1 table, but it isn't actually so.

--
Peter Geoghegan

Attachment Content-Type Size
brin-order-test.patch text/x-patch 1013 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-06-02 02:44:22 Minor improvement to func.sgml
Previous Message Jim Nasby 2015-06-02 00:35:39 Re: PostgreSQL 8.3 index page count clarification