| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel query and temp_file_limit |
| Date: | 2016-07-05 17:58:17 |
| Message-ID: | CAM3SWZRrFVVhwY2whyZ5fNoUcyV4opT+YyPQhKBWBy3-3pfrjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 5, 2016 at 7:45 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Since Peter doesn't seem in a hurry to produce a patch for this issue,
> I wrote one. It is attached. I'll commit this in a day or two if
> nobody objects.
Sorry about the delay.
Your patch seems reasonable, but I thought we'd also want to change
"per session" to "per session (with an additional temp_file_limit
allowance within each parallel worker)" for temp_file_limit.
I think it's worthwhile noting this for temp_file_limit specifically,
since it's explicitly a per session limit, whereas users are quite
used to the idea that work_mem might be doled out multiple times for
multiple executor nodes.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2016-07-05 18:06:38 | reserved role names |
| Previous Message | CharSyam | 2016-07-05 16:48:30 | Re: Typo Patch |