tuplesort.c's copytup_index() is dead code

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: tuplesort.c's copytup_index() is dead code
Date: 2016-06-24 02:08:59
Message-ID: CAM3SWZRcG5a3bLs1eUtBixE-D2ydvUJ0WJa+qfDJiqr=mwTswg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Commit 9f03ca915 removed the only COPYTUP() call that could reach
copytup_index() in practice, making copytup_index() dead code.

The attached patch removes this dead code, in line with the existing
copytup_datum() case, where tuplesort.c also doesn't directly support
COPYTUP() (due to similar considerations around memory management).

--
Peter Geoghegan

Attachment Content-Type Size
0001-Remove-dead-COPYTUP-routine-in-tuplesort.c.patch text/x-patch 2.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2016-06-24 02:16:58 Odd behavior with domains
Previous Message Joshua D. Drake 2016-06-24 02:04:30 Odd behavior with domains