Should pg_stat_bgwriter.buffers_backend_fsync be removed?

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Should pg_stat_bgwriter.buffers_backend_fsync be removed?
Date: 2014-04-27 02:42:47
Message-ID: CAM3SWZR_JQWeD99XZFfWh9+jbuuscR0xdjzY9BYbww-CS8S_oQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Backend fsyncs are theoretically still possible after the fsync
request queue compaction patch (which was subsequently back-patched to
all supported release branches). However, I'm reasonably confident
that that patch was so effective as to make a backend fsync all but
impossible. As such, it seems like the buffers_backend_fsync column in
the pg_stat_bgwriter view is more or less obsolete.

I suggest removing it for 9.5, and instead logging individual
occurrences of backend fsync requests within ForwardFsyncRequest(). It
seems fair to treat that as an anomaly to draw particular attention
to.

--
Peter Geoghegan

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-04-27 04:14:56 Re: Hashable custom types
Previous Message Greg Stark 2014-04-27 01:52:27 Re: UUIDs in core WAS: 9.4 Proposal: Initdb creates a single table