| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |
| Date: | 2016-07-02 05:40:55 |
| Message-ID: | CAM3SWZQnCEuBEWyFmzMkxtf9nkEiWYFOOnBObCT96YWiW2wpkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 1, 2016 at 10:01 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> I'm happy that I can do at least that much, but I see no reason to not
>> go significantly further.
>
> Don't risk bundling tests for other sorting scenarios. A minimal test for the
> bug in question helps to qualify your patch as an exemplary bug fix. Broader
> test coverage evicts your patch from that irreproachable category, inviting
> reviewers to determine that you went too far.
I have no intention of attempting to shoehorn tests for other sorting
scenarios into this bugfix. But, I will wait for Robert to comment on
what I've said before acting.
We should be more ambitious about adding test coverage to tuplesort.c.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-07-02 06:08:36 | Re: Re: [ADMIN] problems using pg_start_backup/pg_stop_backup and pg_basebackup at same time |
| Previous Message | Noah Misch | 2016-07-02 05:01:19 | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |