Re: BUG #12799: libpq - SSL pqsecure_read() doesn't clean openssl error queue before reading

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Dave Vitek <dvitek(at)grammatech(dot)com>
Cc: pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #12799: libpq - SSL pqsecure_read() doesn't clean openssl error queue before reading
Date: 2016-02-18 22:16:05
Message-ID: CAM3SWZQm7Y3NbvyuAOsFvHvGqVGCJk6YmN+gWTuavezp8PPZPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Feb 18, 2016 at 2:11 PM, Dave Vitek <dvitek(at)grammatech(dot)com> wrote:
> We independently ran into this, diagnosed it, and fixed it. Here is the
> complete patch covering every use of SSL_get_error.

I posted a patch for this issue independently, and quite recently:

https://commitfest.postgresql.org/9/520/

Do you happen to have any idea why there has been an uptick in problem
reports about this recently, despite the fact that it's been an issue
for a while (that's been the case within Heroku, at least)? Are you
aware that there is some specific trend behind that?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Dave Vitek 2016-02-18 22:33:19 Re: BUG #12799: libpq - SSL pqsecure_read() doesn't clean openssl error queue before reading
Previous Message Dave Vitek 2016-02-18 22:11:35 Re: BUG #12799: libpq - SSL pqsecure_read() doesn't clean openssl error queue before reading