From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Raising our compiler requirements for 9.6 |
Date: | 2015-07-01 18:05:57 |
Message-ID: | CAM3SWZQf_zP5W-LyUjys1z-exLw3LnZkSvXeJzc0YU1a3KwunQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 1, 2015 at 9:14 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> At the very least I think we should start to rely on 'static inline's
> working. There is not, and hasn't been for a while, any buildfarm animal
> that does not support it and we go through some ugly lengths to avoid
> relying on inline functions in headers. It's a feature that has been
> there in most compilers long before C99.
>
> My feeling is that we shouldn't go the full way to C99 because there's
> still common compilers without a complete coverage. But individual
> features are fine.
I am in full agreement.
> The list of features, in the order of perceived importance, that might
> be worthwhile thinking about are:
> * static inline
> * variadic macros
> * designated initializers (e.g. somestruct foo = { .bar = 3 } )
> * // style comments (I don't care, but it comes up often enough ...)
I don't want to add // style comments, FWIW.
What is the state of support like for variadic macros and designated
initializers? Unlike static inline, I am not aware that they are
something that was widely implemented before C99 was formalized.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2015-07-01 18:19:47 | Re: Refactoring speculative insertion with unique indexes a little |
Previous Message | Andres Freund | 2015-07-01 18:00:59 | Re: NULL passed as an argument to memcmp() in parse_func.c |