| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me |
| Date: | 2014-01-28 02:33:11 |
| Message-ID: | CAM3SWZQUwrOW+8VbNNix+mH818=C1jD9LgW6moH82Ef9VV1KnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jan 27, 2014 at 6:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Timed just right"? I could see it possibly happening due to queryid
> collisions, but I'm not seeing how it would happen absent such a hash
> collision.
Consider what happens when there is a pg_stat_statements_reset() call
query after another query's parse analysis, but before its execution
finishes. That's one obvious way. But you don't even need a reset - a
badly timed entry_dealloc() could do it too.
I don't see what hash collisions have to do with it, though.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-01-28 02:40:38 | Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me |
| Previous Message | KONDO Mitsumasa | 2014-01-28 02:31:23 | Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-01-28 02:40:38 | Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me |
| Previous Message | KONDO Mitsumasa | 2014-01-28 02:31:23 | Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me |