Re: [PATCH] Report exit code from external recovery commands properly

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Report exit code from external recovery commands properly
Date: 2013-11-30 23:56:00
Message-ID: CAM3SWZQ-w7uGiF5-6gvvm3=4-s6rpPkJRJXiZVaR6d_VX3Zedg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 24, 2013 at 5:11 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> How about this?

Hmm. You say:

+ If the command returns a nonzero exit status then a warning log
+ message will be written. An exception is that if the command was
+ terminated by a signal or an error by the shell (such as command not
+ found), a fatal error will be raised.

But in the case of the archiver, in contrast to the startup process,
this isn't really a big deal. It'll just pick up where it left off.
Whereas the reaper code shuts down the system if this happens in the
startup process. In my opinion that's a distinction that bears
emphasizing.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-11-30 23:58:58 Re: Incomplete freezing when truncating a relation during vacuum
Previous Message Tom Lane 2013-11-30 23:48:02 Re: [GENERAL] pg_upgrade ?deficiency