Re: PassDownLimitBound for ForeignScan/CustomScan

From: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
To: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: PassDownLimitBound for ForeignScan/CustomScan
Date: 2016-09-06 14:22:22
Message-ID: CAM2+6=XFvUPny1Upt5_3zJN-=0w=1v1jY+qAof9Nyx6ZeW+EbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Changes look good to me.

However there are couple of minor issues need to be fixed.

1.
"under" repeated on second line. Please remove.
+ if and when <structname>CustomScanState</> is located under
+ under <structname>LimitState</>; which implies the underlying node is
not

2.
Typo: dicsussion => discussion
Please fix.

Apart from this I see no issues.

Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-09-06 14:41:26 pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL
Previous Message Simon Riggs 2016-09-06 14:17:53 Re: Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL