From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
---|---|
To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, sean(dot)johnston(at)edgeintelligence(dot)com, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW |
Date: | 2017-11-15 08:51:33 |
Message-ID: | CAM2+6=W5Kcx+YYhXiVTQr+X6zzW12i705A1dSzeu8gRzKG=Yug@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Fri, Nov 10, 2017 at 6:14 PM, Ashutosh Bapat <
ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>
> + /*
> + * Pushable, add to tlist. We need to create a tle for this
> + * expression and need to transfer the sortgroupref too. We
> cannot
> + * use add_to_flat_tlist() here as it avoids the duplicate
> entries
> + * in the targetlist but here we want those duplicate entries
> as
> + * there can be multiple GROUP BY expressions pointing to the
> same
> + * column at different positions.
> + */
> + tle = makeTargetEntry((Expr *) expr, list_length(tlist) + 1,
> NULL,
> + false);
> + tle->ressortgroupref = sgref;
> + tlist = lappend(tlist, tle);
>
> May be we want to use add_flat_to_tlist() when sgref is not present to
> avoid
> duplicate entries.
>
>
These code changes are already inside sgref check. And for other places we
do use add_to_flat_tlist().
>
> --
> Best Wishes,
> Ashutosh Bapat
> EnterpriseDB Corporation
> The Postgres Database Company
>
--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Jeevan Chalke | 2017-11-15 09:06:43 | Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW |
Previous Message | Michael Paquier | 2017-11-15 01:23:20 | Re: [BUGS] BUG #14866: The generated constraint in the typed table causes the server to crash |