Re: jsonpath: Inconsistency of timestamp_tz() Output

From: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: jsonpath: Inconsistency of timestamp_tz() Output
Date: 2024-07-22 07:12:21
Message-ID: CAM2+6=VDEfxDz1G0kApsdqd8q_SQkr71kS8LMgZg_meiXYokmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 19, 2024 at 7:35 PM David E. Wheeler <david(at)justatheory(dot)com>
wrote:

> On Jul 10, 2024, at 11:19, David E. Wheeler <david(at)justatheory(dot)com> wrote:
>
> > Oh, and the time and date were wrong, too, because I blindly used the
> same conversion for dates as for timestamps. Fixed in v2.
> >
> > PR: https://github.com/theory/postgres/pull/7
> > CF: https://commitfest.postgresql.org/49/5119/
>
> Rebase on 5784a49. No other changes. I would consider this a bug in
> features added for 17.
>

I agree with David that we need to set the tz explicitly as the JsonbValue
struct maintains that separately.

However, in the attached version, I have added some comments and also,
fixed some indentation.

Thanks

>
> Best,
>
> David
>
>

--

*Jeevan Chalke*

*Principal, ManagerProduct Development*

enterprisedb.com <https://www.enterprisedb.com>

Attachment Content-Type Size
v4-0001-Preserve-tz-when-converting-to-jsonb-timestamptz.patch application/octet-stream 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sutou Kouhei 2024-07-22 07:45:40 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Li, Yong 2024-07-22 07:11:15 Re: Make COPY format extendable: Extract COPY TO format implementations