Re: Department of Redundancy Department: makeNode(FuncCall) division

On Mon, Jul 1, 2013 at 6:16 AM, David Fetter <david(at)fetter(dot)org> wrote:

> On Fri, Jun 28, 2013 at 01:28:35PM -0400, Peter Eisentraut wrote:
> > On 6/28/13 11:30 AM, Robert Haas wrote:
> > > On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> David Fetter <david(at)fetter(dot)org> writes:
> > >>> Please find attached the latest patch.
> > >>
> > >> I remain of the opinion that this is simply a bad idea. It is unlike
> > >> our habits for constructing other types of nodes, and makes it harder
> > >> not easier to find all the places that need to be updated when adding
> > >> another field to FuncCall.
> > >
> > > I think it's a nice code cleanup. I don't understand your objection.
> >
> > Yeah, I was reading the patch thinking, yes, finally someone cleans that
> up.
>
> Please find enclosed a patch reflecting the changes that de-reserved
> OVER as a keyword.
>

I have re-validated this new patch and it looks good to go in now.

I saw that it's already marked ready for committer.

Thanks David

> Cheers,
> David.
> --
> David Fetter <david(at)fetter(dot)org> http://fetter.org/
> Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
> Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
> iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
>
> Remember to vote!
> Consider donating to Postgres: http://www.postgresql.org/about/donate
>

--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.