Re: [PATCH] Filter error log statements by sqlstate

Hi Oskari,

I had a quick look over the patch (Not compiled though). Here are few
comments on the changes:

1. Documentation is missing and thus becomes difficult to understand what
exactly you are trying to do. Or in other words, user will be uncertain
about
using it more efficiently.
2. Some more comments required. At each new function and specifically at
get_sqlstate_error_level().
3. Please add test-case if possible.
4. Some code part does not comply with PostgreSQL indentation style. (Can be
ignored as it will pass through pg_indent, but better fix it).
5. You have used ""XX000:warning," string to get maximum possible length of
the valid sqlstate:level identifier. It's perfect, but small explanation
about
that will be good there. Also in future if we have any other error level
which
exceeds this, we need changes here too. Right ?

I will look into this further. But please have your attention on above
points.

Thanks

On Fri, Jan 10, 2014 at 12:56 AM, Oskari Saarenmaa <os(at)ohmu(dot)fi> wrote:

> Allow the default log_min_error_statement to be overridden per sqlstate to
> make it possible to filter out some error types while maintaining a low
> log_min_error_statement or enable logging for some error types when the
> default is to not log anything.
>
> I've tried to do something like this using rsyslog filters, but that's
> pretty awkward and doesn't work at all when the statement is split to
> multiple syslog messages.
>
> https://github.com/saaros/postgres/compare/log-by-sqlstate
>
> src/backend/utils/error/elog.c | 183 ++++++++++++++++++++++++++++++
> ++++++++++-
> src/backend/utils/misc/guc.c | 14 +++-
> src/include/utils/guc.h | 4 +
> src/include/utils/guc_tables.h | 1 +
> 4 files changed, 199 insertions(+), 3 deletions(-)
>
> / Oskari
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.