| From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Subject: | Re: patch: option --if-exists for pg_dump |
| Date: | 2014-01-30 09:31:51 |
| Message-ID: | CAM2+6=Uv3NpZgvnquN7ehbmeomduhRXRvJmijbeqN2i=8iPRgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Pavel,
it should be fixed by
>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b152c6cd0de1827ba58756e24e18110cf902182acommit
>>
>
Ok. Good.
Sorry I didn't update my sources. Done now. Thanks
>
>>
>>>
>>> Also, I didn't quite understand these lines of comments:
>>>
>>> /*
>>> * Descriptor string (te-desc) should not be
>>> same as object
>>> * specifier for DROP STATEMENT. The DROP
>>> DEFAULT has not
>>> * IF EXISTS clause - has not sense.
>>> */
>>>
>>> Will you please rephrase ?
>>>
>>
>> I can try it - .
>>
>> A content of te->desc is usually substring of DROP STATEMENT with one
>> related exception - CONSTRAINT.
>> Independent to previous sentence - ALTER TABLE ALTER COLUMN DROP DEFAULT
>> doesn't support IF EXISTS - and therefore it should not be injected.
>>
>
> is it ok?
>
Fine with me.
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2014-01-30 09:37:07 | Re: [PATCH] Filter error log statements by sqlstate |
| Previous Message | Christian Kruse | 2014-01-30 09:25:05 | Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() |