Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)

From: Greg Stark <stark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, obartunov(at)gmail(dot)com, Andrew Dunstan <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)
Date: 2015-12-30 16:08:48
Message-ID: CAM-w4HPNB=BWJsQiKGWJ0Jxn_hM3QHfZwOvq+tEkB2oLo4K77A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alternately the buildfarm could be changed to retain earlier builds and use
dependencies to reduce build times. This would have the benefit of
detecting dependency failures. At the expense of a lot more noise, at least
until we Orrin out whatever dependency failures are there now.

Or we could add extra rules so that if you don't configure with
dependencies we check for unclean builds and error out. This would make at
least accidental unclean builds much led likely.
On 30 Dec 2015 16:49, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> [ A change as significant as this should not be debated in a thread with
> a title that suggests it's of interest to only one or two people ]
>
> > On Wed, Dec 30, 2015 at 5:44 PM, Andres Freund <andres(at)anarazel(dot)de>
> wrote:
> >> I still maintain that --enable-depend should be on by default. We're
> >> absurdly optimizing towards saving a handful of cycles in scenarios
> >> which are usually bottlenecked by other things (build boxes spend more
> >> times on tests and such)
>
> Nonsense. The buildfarm will simply get slower, and at least for my
> animals it's too damn slow already. We could fix that by having the
> buildfarm script automatically add --disable-depend; but if we're going
> to change this, we should roll out that script update BEFORE we change
> it, not after.
>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-12-30 16:13:31 Re: --enable-depend by default (was Re: Patch: fix lock contention for HASHHDR.mutex)
Previous Message Tom Lane 2015-12-30 16:02:39 Re: rows estimate in explain analyze for the BRIN index