| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Temporary tables versus wraparound... again |
| Date: | 2023-04-05 17:26:53 |
| Message-ID: | CAM-w4HP8vTq3Q-LipBq9D2_ihXB2o1_aQPYR7+FJsaY5G_1Q_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 5 Apr 2023 at 11:15, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> The freebsd test that failed is running tests in parallel, against an existing
> cluster. In that case it's expected that there's some concurrency.
>
> Why does this cause your tests to fail? They're in separate databases, so the
> visibility effects of the concurrent tests should be somewhat limited.
Because I'm checking that relfrozenxid was updated but any concurrent
transactions even in other databases hold back the xmin.
Honestly I'm glad I wrote the test because it was hard to know whether
my code was doing anything at all without it (and it wasn't in the
first cut...) But I don't think there's much value in having it be in
the regression suite. We don't generally write tests to ensure that a
specific internal implementation behaves in the specific way it was
written to.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-04-05 17:27:12 | pgsql: Add smgrzeroextend(), FileZero(), FileFallocate() |
| Previous Message | Greg Stark | 2023-04-05 17:19:42 | Re: Schema variables - new implementation for Postgres 15 |