| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Andrei Zubkov <zubkov(at)moonset(dot)ru> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
| Date: | 2022-04-01 15:38:52 |
| Message-ID: | CAM-w4HOTWdLZfw1VwOsk-TyT-VK_MxSNXuf0NU8W866P_T13RQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
FYI this has a compiler warning showing up on the cfbot:
[13:19:51.544] pg_stat_statements.c: In function ‘entry_reset’:
[13:19:51.544] pg_stat_statements.c:2598:32: error:
‘minmax_stats_reset’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
[13:19:51.544] 2598 | entry->minmax_stats_since = minmax_stats_reset;
[13:19:51.544] | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
If the patch is otherwise ready to commit then this is an issue that
should be fixed before marking it ready to commit.
Given that this is the last week before feature freeze it'll probably
get moved to a future commitfest unless it's ready to commit.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2022-04-01 15:42:38 | Patches with failing tests in Commitfest |
| Previous Message | Greg Stark | 2022-04-01 15:27:56 | Re: Removing unneeded self joins |