Re: pgsql: Add ANALYZE into regression tests

From: Greg Stark <stark(at)mit(dot)edu>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add ANALYZE into regression tests
Date: 2014-04-13 20:24:55
Message-ID: CAM-w4HNjztP2hsbHXU1yB8j0bi6iKQmdf3PGRaiYzkofPVupuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Yeah I think this is OK.

But the original goal seems like it would be easier and better done with an
immutable function which lies and calls elog to leak information. That's
the actual attack this is supposed to protect against anyways.

That would make the tests more robust against other changes causing
failures. Even things like changing explain output formatting for example.

--
greg

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2014-04-14 00:41:15 Re: pgsql: Add ANALYZE into regression tests
Previous Message Tom Lane 2014-04-13 17:59:27 pgsql: Improve some O(N^2) behavior in window function evaluation.

Browse pgsql-hackers by date

  From Date Subject
Next Message John Mudd 2014-04-13 20:27:39 Re: Debug strategy for musl Postgres?
Previous Message John Mudd 2014-04-13 20:19:34 Re: Debug strategy for musl Postgres?