Re: [PATCH 0/3] Work around icc miscompilation

From: Greg Stark <stark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Xi Wang <xi(dot)wang(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH 0/3] Work around icc miscompilation
Date: 2013-02-23 17:42:16
Message-ID: CAM-w4HN5GR9XZDg0g6j473rEdZCut=T5w4cO8hV23js4bNxvWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 23, 2013 at 5:25 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Really? Can't "INT_MAX - a" overflow?

I guess I shouldn't have tried summarizing the code and just pasted
some real code in for fear of getting it wrong. I was thinking of
unsigned arithmetic when I wrote that.

The point being that the compiler isn't going to make optimization
based on code that comes later if that code wouldn't have run in the
same flow of execution.

--
greg

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2013-02-23 17:55:08 Re: Show type in psql SELECT
Previous Message Andrew Dunstan 2013-02-23 17:39:57 Re: make: *** pg_xlogdump: No such file or directory. Stop.