Re: Patch: raise default for max_wal_segments to 1GB

From: Greg Stark <stark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Patch: raise default for max_wal_segments to 1GB
Date: 2015-03-04 18:02:00
Message-ID: CAM-w4HN06CA0sj7DbnwzrwA9n2W5757QWFHMK3HO7MhqEE-XtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 3, 2015 at 7:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Now, if we were to change the server so that it *refused* settings that
> didn't have a unit, that argument would become moot. But I'm not going
> to defend the castle against the villagers who will show up if you do
> that.

That might be something we could get away with eventually if we put in
a warning like this for a few years:

WARNING: Using default units of seconds for GUC tcp_keepalives

Though we'll have to deal with the "0 means system default" and "-1
means really really disabled" stuff.

--
greg

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-03-04 18:10:24 Re: Normalizing units for postgresql.conf WAS: Patch: raise default for max_wal_segments to 1GB
Previous Message Bruce Momjian 2015-03-04 17:58:57 Re: MD5 authentication needs help