| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: Recovery inconsistencies, standby much larger than primary |
| Date: | 2014-02-12 14:37:59 |
| Message-ID: | CAM-w4HMhtBR0u6_T=aTNY2B2eY4bswmHd-2Wt7Fc+fUD-+9aWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
So here's my attempt to rewrite this logic. I ended up refactoring a
bit because I found it unnecessarily confusing having the mode
branches in several places. I think it's much clearer just having two
separate pieces of logic for RBM_NEW and the extension cases since all
they have in common is the ReadBuffer call.
I have to say, it scares the hell out of me that there are no
regression tests for this code. I'm certainly not comfortable
committing it without a few other people reading it if I haven't even
run the code once. At least I know it compiles...
| Attachment | Content-Type | Size |
|---|---|---|
| xlog-extend-relations-carefully.patch | text/x-patch | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-02-12 14:49:18 | Re: Performance Improvement by reducing WAL for Update Operation |
| Previous Message | Ants Aasma | 2014-02-12 14:10:51 | Re: Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease |